fix: enforce carrier-specific channel group routing

api/src/channels/channels.service.spec.ts

@@ -19,6 +19,7 @@ function createPrismaMock() {
     unitPrice: 3,
     status: 'active',
     config: { serviceId: 'SMS' },
+    sendRegion: '山东',
     reportFields: [{ code: 'license', name: '营业执照', fieldType: 'file', required: true, description: null, sortOrder: 1, status: 'active' }],
   };
   return {
@@ -43,6 +44,7 @@ function createPrismaMock() {
     channelHealthMetric: { findMany: jest.fn() },
     smsChannelGroup: {
       findMany: jest.fn(),
+      findUnique: jest.fn().mockResolvedValue({ id: 'group-1', code: 'G-MOBILE', name: '移动组', carrier: 'mobile', status: 'active' }),
       create: jest.fn().mockImplementation(({ data }) => Promise.resolve({ id: 'group-1', ...data })),
     },
     smsChannelGroupItem: {
@@ -114,7 +116,7 @@ describe('ChannelsService', () => {
       passwordCipher: 'secret',
       srcId: '10690000',
     });
-    await service.createGroup({ code: 'G-MOBILE', name: '移动组', retryEnabled: true, retryTimeLimitHours: 24 });
+    await service.createGroup({ code: 'G-MOBILE', name: '移动组', carrier: 'mobile', retryEnabled: true, retryTimeLimitHours: 24 });
     await service.createRouteRule({ tenantId: 'tenant-1', applicationId: 'app-1', groupId: 'group-1', carrier: 'mobile' });
 
     expect(prisma.smsChannel.create).toHaveBeenCalledWith({
@@ -127,7 +129,7 @@ describe('ChannelsService', () => {
       }),
     });
     expect(prisma.smsChannelGroup.create).toHaveBeenCalledWith({
-      data: expect.objectContaining({ retryEnabled: true, retryTimeLimitHours: 24 }),
+      data: expect.objectContaining({ carrier: 'mobile', retryEnabled: true, retryTimeLimitHours: 24 }),
     });
     expect(prisma.channelRouteRule.create).toHaveBeenCalledWith({
       data: expect.objectContaining({
@@ -146,8 +148,78 @@ describe('ChannelsService', () => {
     const prisma = createPrismaMock();
     const service = new ChannelsService(prisma as never);
 
-    expect(() => service.createRouteRule({ tenantId: 'tenant-1', applicationId: 'app-1', groupId: 'group-1', carrier: 'mobile', channelId: 'channel-1' }))
-      .toThrow('Route rules can only bind channel groups');
+    await expect(service.createRouteRule({ tenantId: 'tenant-1', applicationId: 'app-1', groupId: 'group-1', carrier: 'mobile', channelId: 'channel-1' }))
+      .rejects.toThrow('Route rules can only bind channel groups');
+    expect(prisma.channelRouteRule.create).not.toHaveBeenCalled();
+  });
+
+  it('enforces single-carrier channel groups and compatible group items', async () => {
+    const prisma = createPrismaMock();
+    const service = new ChannelsService(prisma as never);
+
+    expect(() => service.createGroup({ code: 'G-ALL', name: '三网组', carrier: 'all' })).toThrow('carrier must be mobile, unicom, or telecom');
+
+    await service.addGroupItem({ groupId: 'group-1', channelId: 'channel-1', carrier: 'mobile', province: '山东', priority: 10 });
+    expect(prisma.smsChannelGroupItem.create).toHaveBeenCalledWith({
+      data: expect.objectContaining({ groupId: 'group-1', channelId: 'channel-1', carrier: 'mobile', province: '山东' }),
+    });
+
+    await expect(service.addGroupItem({ groupId: 'group-1', channelId: 'channel-1', carrier: 'unicom' }))
+      .rejects.toThrow('Channel group items must use the same carrier');
+
+    const compatibleChannel = {
+      id: 'channel-1',
+      code: 'CMPP-A',
+      name: '主通道',
+      carrier: 'mobile',
+      protocol: 'CMPP',
+      gatewayHost: '127.0.0.1',
+      gatewayPort: 17890,
+      enterpriseCode: 'EC',
+      account: 'sp',
+      passwordCipher: 'secret',
+      srcId: '10690000',
+      cmppVersion: '3.0',
+      rateLimitPerSecond: 100,
+      unitPrice: 3,
+      status: 'active',
+      config: { serviceId: 'SMS' },
+      sendRegion: '山东',
+    };
+    prisma.smsChannel.findUnique.mockResolvedValueOnce({ ...compatibleChannel, carrier: 'telecom' });
+    await expect(service.addGroupItem({ groupId: 'group-1', channelId: 'channel-x', carrier: 'mobile' }))
+      .rejects.toThrow('Channel carrier is not compatible');
+
+    prisma.smsChannel.findUnique.mockResolvedValue(compatibleChannel);
+    prisma.smsChannelGroupItem.findFirst
+      .mockResolvedValueOnce(null)
+      .mockResolvedValueOnce({ id: 'province-item', province: '山东' });
+    await expect(service.addGroupItem({ groupId: 'group-1', channelId: 'channel-2', carrier: 'mobile', province: '山东' }))
+      .rejects.toThrow('同一通道组内同一省份只能配置一个通道');
+  });
+
+  it('rejects province routes with mismatched channel sendRegion and duplicate national priorities', async () => {
+    const prisma = createPrismaMock();
+    const service = new ChannelsService(prisma as never);
+
+    prisma.smsChannel.findUnique.mockResolvedValue({ id: 'channel-henan', carrier: 'all', sendRegion: '河南' });
+    await expect(service.addGroupItem({ groupId: 'group-1', channelId: 'channel-henan', carrier: 'mobile', province: '山东' }))
+      .rejects.toThrow('Province route must use a channel with the same sendRegion');
+
+    prisma.smsChannel.findUnique.mockResolvedValue({ id: 'channel-national', carrier: 'all', sendRegion: '全国' });
+    prisma.smsChannelGroupItem.findFirst
+      .mockResolvedValueOnce(null)
+      .mockResolvedValueOnce({ id: 'national-priority-1', province: null, priority: 1 });
+    await expect(service.addGroupItem({ groupId: 'group-1', channelId: 'channel-national', carrier: 'mobile', priority: 1 }))
+      .rejects.toThrow('同一通道组内全国通道优先级不能重复');
+  });
+
+  it('requires route rule carrier to match the channel group carrier', async () => {
+    const prisma = createPrismaMock();
+    const service = new ChannelsService(prisma as never);
+
+    await expect(service.createRouteRule({ tenantId: 'tenant-1', applicationId: 'app-1', groupId: 'group-1', carrier: 'unicom' }))
+      .rejects.toThrow('Route rule carrier must match the channel group carrier');
     expect(prisma.channelRouteRule.create).not.toHaveBeenCalled();
   });