fix: close sms scheduling and billing gaps

2026-07-01 18:56:05 +08:00
parent 8ba4ef8a13
commit f8c9b78c21
28 changed files with 1480 additions and 26 deletions
@@ -1,6 +1,6 @@
 import { Body, Controller, Get, Param, Post, Query } from '@nestjs/common';
 import { ApiTags } from '@nestjs/swagger';
-import { ReviewDto, SmsConfigService } from './sms-config.service';
+import { ReviewDto, SmsConfigService, StatusChangeDto } from './sms-config.service';

@ApiTags('admin-sms-config')
@Controller('admin')
@@ -46,4 +46,19 @@ export class AdminSmsConfigController {
  rejectTemplate(@Param('id') templateId: string, @Body() body: ReviewDto) {
    return this.smsConfig.rejectTemplate(templateId, body);
  }
+
+  @Post('enterprise-applications/:id/status')
+  changeApplicationStatus(@Param('id') applicationId: string, @Body() body: StatusChangeDto) {
+    return this.smsConfig.changeApplicationStatus(applicationId, body);
+  }
+
+  @Post('enterprise-signatures/:id/status')
+  changeSignatureStatus(@Param('id') signatureId: string, @Body() body: StatusChangeDto) {
+    return this.smsConfig.changeSignatureStatus(signatureId, body);
+  }
+
+  @Post('enterprise-templates/:id/status')
+  changeTemplateStatus(@Param('id') templateId: string, @Body() body: StatusChangeDto) {
+    return this.smsConfig.changeTemplateStatus(templateId, body);
+  }
 }
@@ -6,6 +6,7 @@ import {
  CreateSmsApplicationDto,
  CreateSmsSignatureDto,
  CreateSmsTemplateDto,
+  StatusChangeDto,
  SmsConfigService,
 } from './sms-config.service';

@@ -24,6 +25,16 @@ export class ClientSmsConfigController {
    return this.smsConfig.createApplication(body);
  }

+  @Post('applications/:id/secret/reset')
+  resetApplicationSecret(@Param('id') applicationId: string, @Body() body: StatusChangeDto) {
+    return this.smsConfig.resetApplicationSecret(applicationId, body);
+  }
+
+  @Post('applications/:id/status')
+  changeApplicationStatus(@Param('id') applicationId: string, @Body() body: StatusChangeDto) {
+    return this.smsConfig.changeApplicationStatus(applicationId, body);
+  }
+
  @Get('signatures')
  listSignatures(@TenantId() tenantId?: string) {
    return this.smsConfig.listSignatures(tenantId);
@@ -44,6 +55,11 @@ export class ClientSmsConfigController {
    return this.smsConfig.submitSignature(signatureId);
  }

+  @Post('signatures/:id/status')
+  changeSignatureStatus(@Param('id') signatureId: string, @Body() body: StatusChangeDto) {
+    return this.smsConfig.changeSignatureStatus(signatureId, body);
+  }
+
  @Get('templates')
  listTemplates(@TenantId() tenantId?: string) {
    return this.smsConfig.listTemplates(tenantId);
@@ -58,4 +74,9 @@ export class ClientSmsConfigController {
  submitTemplate(@Param('id') templateId: string) {
    return this.smsConfig.submitTemplate(templateId);
  }
+
+  @Post('templates/:id/status')
+  changeTemplateStatus(@Param('id') templateId: string, @Body() body: StatusChangeDto) {
+    return this.smsConfig.changeTemplateStatus(templateId, body);
+  }
 }
@@ -0,0 +1,35 @@
+import { SmsConfigService } from './sms-config.service';
+
+function createPrismaMock() {
+  return {
+    smsSignature: {
+      findUnique: jest.fn().mockResolvedValue({ id: 'sig-1', tenantId: 'tenant-1', auditStatus: 'pending' }),
+      update: jest.fn(),
+    },
+    smsTemplate: {
+      findUnique: jest.fn().mockResolvedValue({ id: 'tpl-1', tenantId: 'tenant-1', auditStatus: 'pending' }),
+      update: jest.fn(),
+    },
+    auditRecord: {
+      create: jest.fn(),
+      findMany: jest.fn(),
+    },
+    user: {
+      findUnique: jest.fn().mockResolvedValue(null),
+    },
+  };
+}
+
+describe('SmsConfigService', () => {
+  it('rejects unknown reviewer ids before writing audit records', async () => {
+    const prisma = createPrismaMock();
+    const service = new SmsConfigService(prisma as never);
+
+    await expect(service.approveSignature('sig-1', { reviewerId: 'missing-user' })).rejects.toThrow(
+      'reviewerId does not reference an existing user',
+    );
+
+    expect(prisma.smsSignature.update).not.toHaveBeenCalled();
+    expect(prisma.auditRecord.create).not.toHaveBeenCalled();
+  });
+});
@@ -1,4 +1,4 @@
-import { Injectable, NotFoundException } from '@nestjs/common';
+import { BadRequestException, Injectable, NotFoundException } from '@nestjs/common';
 import { Prisma } from '@prisma/client';
 import { randomBytes, createHash } from 'node:crypto';
 import { PrismaService } from '../prisma/prisma.service';
@@ -45,6 +45,12 @@ export interface ReviewDto {
  reason?: string;
 }

+export interface StatusChangeDto {
+  status?: string;
+  operatorId?: string;
+  reason?: string;
+}
+
@Injectable()
 export class SmsConfigService {
  constructor(private readonly prisma: PrismaService) {}
@@ -78,6 +84,37 @@ export class SmsConfigService {
    });
  }

+  async resetApplicationSecret(applicationId: string, data: StatusChangeDto = {}) {
+    const application = await this.prisma.smsApplication.findUnique({ where: { id: applicationId } });
+    if (!application) {
+      throw new NotFoundException('Application not found');
+    }
+    const secret = randomBytes(24).toString('hex');
+    const updated = await this.prisma.smsApplication.update({
+      where: { id: applicationId },
+      data: { secretHash: hashSecret(secret) },
+    });
+    await this.writeOperationLog(application.tenantId, data.operatorId, 'sms_application.secret_reset', 'sms_application', applicationId, {
+      reason: data.reason,
+    });
+    return { ...updated, secret };
+  }
+
+  async changeApplicationStatus(applicationId: string, data: StatusChangeDto) {
+    const application = await this.prisma.smsApplication.findUnique({ where: { id: applicationId } });
+    if (!application) {
+      throw new NotFoundException('Application not found');
+    }
+    const status = data.status ?? 'disabled';
+    const updated = await this.prisma.smsApplication.update({ where: { id: applicationId }, data: { status } });
+    await this.writeOperationLog(application.tenantId, data.operatorId, `sms_application.${status}`, 'sms_application', applicationId, {
+      statusBefore: application.status,
+      statusAfter: status,
+      reason: data.reason,
+    });
+    return updated;
+  }
+
  listSignatures(tenantId?: string) {
    return this.prisma.smsSignature.findMany({
      where: tenantId ? { tenantId } : undefined,
@@ -211,11 +248,42 @@ export class SmsConfigService {
    return this.reviewTemplate(templateId, 'rejected', 'reject', data);
  }

+  async changeSignatureStatus(signatureId: string, data: StatusChangeDto) {
+    const signature = await this.prisma.smsSignature.findUnique({ where: { id: signatureId } });
+    if (!signature) {
+      throw new NotFoundException('Signature not found');
+    }
+    const status = data.status ?? 'deleted';
+    const updated = await this.prisma.smsSignature.update({ where: { id: signatureId }, data: { auditStatus: status } });
+    await this.writeOperationLog(signature.tenantId, data.operatorId, `sms_signature.${status}`, 'sms_signature', signatureId, {
+      statusBefore: signature.auditStatus,
+      statusAfter: status,
+      reason: data.reason,
+    });
+    return updated;
+  }
+
+  async changeTemplateStatus(templateId: string, data: StatusChangeDto) {
+    const template = await this.prisma.smsTemplate.findUnique({ where: { id: templateId } });
+    if (!template) {
+      throw new NotFoundException('Template not found');
+    }
+    const status = data.status ?? 'deleted';
+    const updated = await this.prisma.smsTemplate.update({ where: { id: templateId }, data: { auditStatus: status } });
+    await this.writeOperationLog(template.tenantId, data.operatorId, `sms_template.${status}`, 'sms_template', templateId, {
+      statusBefore: template.auditStatus,
+      statusAfter: status,
+      reason: data.reason,
+    });
+    return updated;
+  }
+
  private async reviewSignature(signatureId: string, statusAfter: string, action: string, data: ReviewDto) {
    const signature = await this.prisma.smsSignature.findUnique({ where: { id: signatureId } });
    if (!signature) {
      throw new NotFoundException('Signature not found');
    }
+    const reviewerId = await this.resolveReviewerId(data.reviewerId);

    const updated = await this.prisma.smsSignature.update({
      where: { id: signatureId },
@@ -232,7 +300,7 @@ export class SmsConfigService {
      statusBefore: signature.auditStatus,
      statusAfter,
      reason: data.reason,
-      reviewerId: data.reviewerId,
+      reviewerId,
    });
    return updated;
  }
@@ -242,6 +310,7 @@ export class SmsConfigService {
    if (!template) {
      throw new NotFoundException('Template not found');
    }
+    const reviewerId = await this.resolveReviewerId(data.reviewerId);

    const updated = await this.prisma.smsTemplate.update({
      where: { id: templateId },
@@ -258,14 +327,45 @@ export class SmsConfigService {
      statusBefore: template.auditStatus,
      statusAfter,
      reason: data.reason,
-      reviewerId: data.reviewerId,
+      reviewerId,
    });
    return updated;
  }

+  private async resolveReviewerId(reviewerId?: string) {
+    if (!reviewerId) {
+      return undefined;
+    }
+    const reviewer = await this.prisma.user.findUnique({ where: { id: reviewerId }, select: { id: true } });
+    if (!reviewer) {
+      throw new BadRequestException('reviewerId does not reference an existing user');
+    }
+    return reviewerId;
+  }
+
  private createAuditRecord(data: Prisma.AuditRecordUncheckedCreateInput) {
    return this.prisma.auditRecord.create({ data });
  }
+
+  private writeOperationLog(
+    tenantId: string,
+    userId: string | undefined,
+    action: string,
+    resource: string,
+    resourceId: string,
+    detail: Record<string, unknown>,
+  ) {
+    return this.prisma.operationLog.create({
+      data: {
+        tenantId,
+        userId,
+        action,
+        resource,
+        resourceId,
+        detail: detail as Prisma.InputJsonValue,
+      },
+    });
+  }
 }

 interface TemplateVariableInput {